Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-1362) Warn user if updating module with older PDK version #681

Merged
merged 1 commit into from
Jun 14, 2019
Merged

(PDK-1362) Warn user if updating module with older PDK version #681

merged 1 commit into from
Jun 14, 2019

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Jun 13, 2019

No description provided.

@coveralls
Copy link

coveralls commented Jun 13, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 93.079% when pulling c202bdd on rodjek:pdk-1362 into fa41bb0 on puppetlabs:master.

scotje
scotje reviewed Jun 13, 2019
View reviewed changes
Copy link
Contributor

@scotje scotje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple notes on the verbiage. Probably fine to merge as-is if we make sure to circle back to the exact language once Jean is back.

lib/pdk/cli/update.rb Outdated Show resolved Hide resolved
lib/pdk/cli/update.rb Outdated Show resolved Hide resolved
@rodjek rodjek requested a review from scotje June 14, 2019 00:25
scotje
scotje approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@scotje scotje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@rodjek rodjek merged commit 49623a3 into puppetlabs:master Jun 14, 2019
@rodjek rodjek deleted the pdk-1362 branch June 14, 2019 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotje scotje scotje approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rodjek @coveralls @scotje @chelnak