Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-1366) Update default operatingsystem versions #682

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Jun 13, 2019

No description provided.

@coveralls
Copy link

coveralls commented Jun 13, 2019

Coverage Status

Coverage remained the same at 93.071% when pulling bde5251 on rodjek:pdk-1366 into fa41bb0 on puppetlabs:master.

@SimonHoenscheid
Copy link

SimonHoenscheid commented Jun 13, 2019

The original PR was created to add Arch Linux to the List. That should be covered.
cc @bastelfeak

@SimonHoenscheid
Copy link

Is there a reason to just reference latest stable release? All currently supported versions should be referenced.

@rodjek
Copy link
Contributor Author

rodjek commented Jun 14, 2019

@SimonHoenscheid Thanks for the information around the other EL8 based distros!

The original PR was created to add Arch Linux to the List. That should be covered.

When creating and updating the list of default operating systems we have to balance all the available options with the need to not overload the users with a bunch of options. For that reason we only offer the most common supported operating systems & distributions in the defaults and unfortunately (and I'm speaking as a happy Arch user here) Arch is just not popular enough in the module development community to justify adding it at this time.

Is there a reason to just reference latest stable release?

We only reference the latest stable release rather than all supported releases because when someone is developing a new module, 95% of the time they are writing it for use on the latest release. It may work on older releases of an OS, but that decision should be made by module author and explicitly specified. This helps keep the Forge clean by making it less likely that modules are published with incorrect metadata.

I hope that all makes sense :)

},
'Solaris' => {
'operatingsystem' => 'Solaris',
'operatingsystemrelease' => ['11'],
},
'Windows' => {
'operatingsystem' => 'windows',
'operatingsystemrelease' => ['2008 R2', '2012 R2', '10'],
'operatingsystemrelease' => %w[2019 10],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is a bit tricky. The most common Server OS right now is either 2016 or 2012R2, but 2019 is the latest.

Copy link
Contributor

@glennsarti glennsarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIP IT!!!!

@rodjek rodjek merged commit d468eda into puppetlabs:master Jun 25, 2019
@rodjek rodjek deleted the pdk-1366 branch June 25, 2019 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants