(SDK-240) Adds puppet-lint validation subcommand #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to getting the base puppet-lint validation subcommand working, there are a lot of other plumbing changes included here. A layer of abstraction was added here to be able to genericize the validation commands to "Metadata", "Puppet", and "Ruby" with their respective generic validators. These generic validators will be able to manage subvalidations that can be created to handle the actual tools. e.g. PuppetValidator is a wrapper that includes validation invocation for PuppetLint and PuppetParser. RubyValidator was created for consistency and future tools integrations despite only having rubocop currently as the lone validator.
|
Pushed a commit to fix up the existing tests so that I can rebase the rubocop integration onto this and take advantage of your refactoring :) |
scotje
approved these changes
Jun 9, 2017
DavidS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to getting the base puppet-lint validation subcommand working,
there are a lot of other plumbing changes included here. A layer of abstraction
was added here to be able to genericize the validation commands to
"Metadata", "Puppet", and "Ruby" with their respective generic validators.
These generic validators will be able to manage subvalidations that can be
created to handle the actual tools.
e.g. PuppetValidator is a wrapper that includes validation invocation for
PuppetLint and PuppetParser.
RubyValidator was created for consistency and future tools integrations
despite only having rubocop currently as the lone validator.
Requires #70