Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-1366) Update default operatingsystem versions #711

Merged
merged 1 commit into from
Jul 26, 2019
Merged

(PDK-1366) Update default operatingsystem versions #711

merged 1 commit into from
Jul 26, 2019

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Jul 24, 2019

Reverts #685

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.208% when pulling 7712f13 on revert-685-revert-682-pdk-1366 into 0edc07f on master.

@glennsarti
Copy link
Contributor

Yo dawg...I heard you like reverts....

glennsarti
glennsarti previously approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@glennsarti glennsarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending Green CI

@rodjek
Copy link
Contributor Author

rodjek commented Jul 24, 2019

Holding off merging as I just realised that the new FacterDB release is missing SLES 15 fact sets 🤦‍♂️

@glennsarti glennsarti dismissed their stale review July 24, 2019 06:01

Things have changed.

@rodjek rodjek mentioned this pull request Jul 24, 2019
Merged
@rodjek rodjek changed the title Revert "Revert "(PDK-1366) Update default operatingsystem versions"" (PDK-1366) Update default operatingsystem versions Jul 25, 2019
@rodjek rodjek removed the blocked label Jul 25, 2019
@rodjek
Copy link
Contributor Author

rodjek commented Jul 25, 2019

This should be good to go now

@rodjek rodjek merged commit 370de9c into master Jul 26, 2019
@rodjek rodjek deleted the revert-685-revert-682-pdk-1366 branch July 26, 2019 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotje scotje scotje approved these changes

@glennsarti glennsarti glennsarti left review comments

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rodjek @coveralls @glennsarti @scotje @chelnak