(PDK-1309) Ensure file modes in built modules are sane #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotje
approved these changes
Jul 25, 2019
| entry_meta[:mode] = orig_mode | min_mode | ||
|
|
||
| if entry_meta[:mode] != orig_mode | ||
| PDK.logger.debug(_('Updated permissions of packaged \'%{entry}\' to %{new_mode}') % { |
There was a problem hiding this comment.
I added this logging, I originally had it at WARN but the original report was someone who deliberately developed with a restrictive umask so I though a warning for every file would be annoying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building module tarballs for publishing, we need to sanitise the modes of the tarball entries. Directories should have at least 0755 and files should have at least 0644.