Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FIXUP) Bypass shell invocation for PDK::CLI::Exec::InteractiveCommand #717

Merged
merged 1 commit into from
Jul 31, 2019
Merged

(FIXUP) Bypass shell invocation for PDK::CLI::Exec::InteractiveCommand #717

merged 1 commit into from
Jul 31, 2019

Conversation

scotje
Copy link
Contributor

@scotje scotje commented Jul 30, 2019

Changing the Kernel#system call to invoke the command directly instead
of through a shell seems to fix the missing output issue on Windows when
Powershell is invoked through Cygwin.

@scotje
(FIXUP) Bypass shell invocation for PDK::CLI::Exec::InteractiveCommand
dd9f1a7 
Changing the Kernel#system call to invoke the command directly instead
of through a shell seems to fix the missing output issue on Windows when
Powershell is invoked through Cygwin.
@scotje scotje requested review from rodjek and glennsarti July 30, 2019 23:34
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.065% when pulling dd9f1a7 on scotje:fixup_interactive_cmd into d6aabe1 on puppetlabs:master.

@rodjek rodjek merged commit 675b567 into puppetlabs:master Jul 31, 2019
@scotje scotje deleted the fixup_interactive_cmd branch July 31, 2019 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodjek rodjek rodjek approved these changes

@glennsarti glennsarti Awaiting requested review from glennsarti

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scotje @coveralls @rodjek @chelnak