(PDK-1363) Apply init templates during module convert #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodjek
force-pushed
the
pdk-1363
branch
2 times, most recently
from
7cae8c6
to
42c7d7d
Compare
scotje
approved these changes
Aug 14, 2019
| @@ -68,25 +72,30 @@ def needs_bundle_update? | |||
| def stage_changes! | |||
| metadata_path = 'metadata.json' | |||
|
|
|||
| PDK::Module::TemplateDir.new(template_uri, nil, false) do |templates| | |||
| PDK::Module::TemplateDir.new(template_uri, nil, true) do |templates| | |||
There was a problem hiding this comment.
The PDK::Module::TemplateDir constructor seems like a good candidate for keyword arguments. Not necessarily now though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During
pdk convert, if there are init-only templates for files that do not exist in the module, create them as would be done duringpdk new module.Coverage dropped a bit because there isn't much in the way of unit tests for
PDK::Module::TemplateDircurrently and I don't want this change to get bogged down working on that.