Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-1175) pdk new unit_test #735

Merged
merged 2 commits into from
Aug 28, 2019
Merged

(PDK-1175) pdk new unit_test #735

merged 2 commits into from
Aug 28, 2019

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Aug 23, 2019

Introduces a new pdk command pdk new unit_test which can be used to generate a skeleton unit test for objects like existing classes and defined types. This is not intended to provide retrospec like functionality, but simply provide people with the same "it compiles" skeleton test that the existing generators do automatically.

@coveralls
Copy link

coveralls commented Aug 23, 2019

Coverage Status

Coverage increased (+0.2%) to 91.961% when pulling cf5b986 on rodjek:test_gen into b00c515 on puppetlabs:master.

Copy link
Contributor

@scotje scotje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is looking good, I will go over in more detail on Monday.

I'm with @glennsarti though, I think we need to workshop the subcommand/action UX a bit.

Perhaps we can dark-ship this in the August release and get the functionality tested while we finalize the UX?

@glennsarti
Copy link
Contributor

@rodjek and I had a chat via Slack, and general consensus is pretty much what @scotje said:

  1. Yes the name probably needs to change

  2. We lack shared context around what each Verb actually means so right now it's too easy to bikeshed

  3. It's safe to ship this as "experimental"/"dark ship", and once we get a better naming standard we can move the functionality there.

Copy link
Contributor

@glennsarti glennsarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All ready for merge except to mark this as "experimental" in the summary/comments of the CLI

@glennsarti
Copy link
Contributor

image

@glennsarti glennsarti merged commit a2d4d93 into puppetlabs:master Aug 28, 2019
@rodjek rodjek deleted the test_gen branch August 28, 2019 04:09
@rodjek rodjek added the feature label Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants