Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-1442) Add basic interactive pdk bundle test #736

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

rodjek
Copy link
Contributor

@rodjek rodjek commented Aug 26, 2019

Starts an interactive pry session, generates some output and adds an expectation on the contents of the output. It's not the most rspecy test, but we can extract it into a matcher later if we end up creating a lot more of these tests.

@coveralls
Copy link

coveralls commented Aug 26, 2019

Coverage Status

Coverage remained the same at 91.209% when pulling 07e7835 on rodjek:pdk-1442 into 19f5eea on puppetlabs:master.

@scotje
Copy link
Contributor

scotje commented Aug 26, 2019

Seems that Ruby on Windows doesn't include pty as a built-in. There is a gem (rubysl-pty) that I guess re-adds it via native extensions, but it might also be OK to skip this test on Windows? Or is there another way to right it that will be more Windows-native?

@rodjek
Copy link
Contributor Author

rodjek commented Sep 10, 2019

Closing for now, can reopen when we loop back to this later.

@glennsarti
Copy link
Contributor

@rodjek Looks like you need to guard this on platform (Error on Windows)

bundle exec rake %SUITES%
2 processes for 21 specs, ~ 10 specs per process
An error occurred while loading ./spec/acceptance/bundle_spec.rb. - Did you mean?
                    rspec ./spec/acceptance/build_spec.rb
                    rspec ./spec/acceptance/update_spec.rb
                    rspec ./spec/acceptance/new_module_spec.rb
Failure/Error: require 'pty'
LoadError:
  cannot load such file -- pty
  
# ./spec/acceptance/bundle_spec.rb:2:in `require'
# ./spec/acceptance/bundle_spec.rb:2:in `<top (required)>'
Top 0 slowest examples (0 seconds, 0.0% of total time):
Finished in 0 seconds (files took 1.61 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples
Working in C:/Users/appveyor/AppData/Local/Temp/1/d20191127-1540-teeny3

Copy link
Contributor

@glennsarti glennsarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The require statements need guarding on platform

@rodjek rodjek force-pushed the pdk-1442 branch 4 times, most recently from 16e710d to 7fba244 Compare November 29, 2019 03:06
@rodjek rodjek force-pushed the pdk-1442 branch 4 times, most recently from de2a54d to 77f4daf Compare December 9, 2019 00:14
@rodjek rodjek merged commit 862314c into puppetlabs:master Dec 9, 2019
@rodjek rodjek deleted the pdk-1442 branch December 9, 2019 03:50
@rodjek rodjek added this to the December 2019 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants