(PDK-680) Make pdk test unit interactive by default

[rodjek]

semirhage :0: pdk/foo (git:pdk-680 → origin {3} ?:1!)$ ../bin/pdk test unit --interactive
pdk (INFO): Using Ruby 2.4.6
pdk (INFO): Using Puppet 6.8.1
[✔] Preparing to run the unit tests.
/home/tsharpe/.rbenv/versions/2.4.6/bin/ruby -I/home/tsharpe/.pdk/cache/ruby/2.4.0/gems/rspec-core-3.8.2/lib:/home/tsharpe/.pdk/cache/ruby/2.4.0/gems/rspec-support-3.8.2/lib /home/tsharpe/.pdk/cache/ruby/2.4.0/gems/rspec-core-3.8.2/exe/rspec --pattern spec/\{aliases,classes,defines,functions,hosts,integration,plans,tasks,type_aliases,types,unit\}/\*\*/\*_spec.rb
Failed to retrieve Augeas version: cannot load such file -- augeas
Run options: exclude {:bolt=>true}

foo::bar
  on oraclelinux-7-x86_64

From: /home/tsharpe/code/puppetlabs/pdk/foo/spec/classes/bar_spec.rb @ line 9 :

     4: describe 'foo::bar' do
     5:   on_supported_os.each do |os, os_facts|
     6:     context "on #{os}" do
     7:       let(:facts) { os_facts }
     8:
 =>  9:       it { binding.pry; is_expected.to compile }
    10:     end
    11:   end
    12: end

[1] pry(#<RSpec::ExampleGroups::FooBar::OnOraclelinux7X8664>)>

[natemccurdy]

What happens now if I have a binding.pry line in my spec tests and I run pdk test unit without the --interactive flag? Will it still hang like it currently does?

[scotje]

I think the most recent thing we discussed (documented here: https://tickets.puppetlabs.com/browse/PDK-680?focusedCommentId=678885&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-678885) was making this the default behavior in most cases.

[natemccurdy]

Right, my understanding of the conversation in PDK-680 was that interactive features like pry would work without having to add any additional flags to PDK.

Please excuse me if I'm misunderstanding this particular PR, but it seems to be requiring the flag.

[scotje]

Yeah, I think the PR needs to be revised to reflect that updated expectation. I guess the ticket description/acceptance criteria itself was never updated.

[scotje]

@rodjek see comments above ^^

[coveralls]

Coverage increased (+0.03%) to 92.061% when pulling a6fcbd8 on rodjek:pdk-680 into 378f22d on puppetlabs:master.

[scotje]

Looks good to me!

On a related note, we need to look into the startup time for the puppetlabs_spec_helper tasks because it really seems to be impacting the overall test duration, even after the spec_prep has completed.

[rodjek]

Updated for the new criteria :)