(SDK-244) Add rubocop validation subcommand #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmjen
suggested changes
Jun 13, 2017
| @@ -11,13 +11,18 @@ def self.name | |||
| end | |||
|
|
|||
| def self.cmd | |||
| 'pwd' | |||
| 'rubocop' | |||
There was a problem hiding this comment.
I think for rubocop, we'll need to default target to the #{PDK::Util.module_root}/lib directory instead, because rubocop isn't liking parsing of .rubocop.yml file in the module_root.
There was a problem hiding this comment.
Tried this again on a newly generated module with updated templates, and rubocop is ok with the rubocop.yml, but still finding issues with Gemfile and spec_helper.rb. I'll investigate.
| @@ -4,10 +4,27 @@ | |||
| module PDK | |||
| module Validate | |||
| class BaseValidator | |||
| def self.parse_targets(options) | |||
bmjen
approved these changes
Jun 13, 2017
DavidS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the validators further so that parsing targets from the CLI and invoking the command are part of the base class. This way, the only thing each validator needs to do is implement a method to build an array of arguments to pass to the command