Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#770) Add missing require to PDK::Module::Metadata.from_file #771

Merged
merged 2 commits into from
Oct 15, 2019
Merged

(#770) Add missing require to PDK::Module::Metadata.from_file #771

merged 2 commits into from
Oct 15, 2019

Conversation

hajee
Copy link
Contributor

@hajee hajee commented Oct 9, 2019 •
edited by rodjek
Loading

Fixes #770

@hajee hajee requested a review from a team as a code owner October 9, 2019 11:37
@coveralls
Copy link

coveralls commented Oct 9, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 91.721% when pulling 711a4a8 on enterprisemodules:fix into 38fe1e9 on puppetlabs:master.

rodjek
rodjek previously requested changes Oct 10, 2019
View reviewed changes
lib/pdk/module/metadata.rb Outdated Show resolved Hide resolved
@rodjek rodjek changed the title Fixes issue #770 (#770) Add missing require to PDK::Module::Metadata.from_file Oct 10, 2019
@sanfrancrisko
Copy link
Contributor

Was encountering this issue and can confirm this fix worked for me

@hajee
Copy link
Contributor Author

hajee commented Oct 10, 2019

No clue why travis fails on Ruby 2.3

@scotje scotje merged commit c311c61 into puppetlabs:master Oct 15, 2019
@scotje
Copy link
Contributor

scotje commented Oct 15, 2019

Travis failure appears to have just been a transient issue. Thanks for the contribution @hajee!

@glennsarti glennsarti added this to the November 2019 milestone Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotje scotje scotje approved these changes

@rodjek rodjek rodjek left review comments

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
November 2019
Development

Successfully merging this pull request may close these issues.

rake build gives error NoMethodError: undefined method `package_install?' for PDK::Util:Module
7 participants
@hajee @coveralls @sanfrancrisko @scotje @rodjek @chelnak @glennsarti