(PDK-1519) Print deprecation notice on Ruby < 2.4 #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happens at the start of the global CLI runner block so that it applies to all PDK commands. This doesn't inform users who are purely using PDK as a library though, but I think that they're better served by documenting the upcoming deprecation as well as following semver and performing a major version bump when dropping support for older Rubies.
glennsarti
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happens at the start of the global CLI runner block so that it applies
to all PDK commands.
This doesn't inform users who are purely using PDK as a library though,
but I think that they're better served by documenting the upcoming
deprecation as well as following semver and performing a major version
bump when dropping support for older Rubies.