(PDK-1530) Disable schema validation of config files #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
force-pushed
the
disable-schema-validation
branch
from
aa9b3a2
to
1a2e1f1
Compare
rodjek
reviewed
Oct 29, 2019
Previously the PDK Analytics configuration file had a JSON schema enabled, however the json-schema gem is causing issues. This commit disables the schema validation, while retaining the schema code. Later commits will use the updated json_schemer gem once EOL Rubies support is dropped.
glennsarti
force-pushed
the
disable-schema-validation
branch
from
1a2e1f1
to
8df2441
Compare
rodjek
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference - #777
Previously the PDK Analytics configuration file had a JSON schema enabled,
however the json-schema gem is causing issues. This commit disables the schema
validation, while retaining the schema code. Later commits will use the updated
json_schemer gem once EOL Rubies support is dropped.