(PDK-1169) Add VMWare fallback to PDK::Util::Filesystem.mv #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`File.rename` (used inside of `FileUtils.mv`) raises `Errno::ENOENT` when used inside of a VMWare shared folder on Windows. This adds a fallback to `PDK::Util::Filesystem.mv` that first checks if the source file exists (in case the error is legitimate) and then "moves" the file using copy and remove operations. As this is quite the corner case, there are no tests added but I've tested it on a local VM and it resolves the issue.
|
@rodjek This looks like a manifestation of jruby/jruby#5168 |
|
i.e. can't rename across filesystems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File.rename(used inside ofFileUtils.mv) raisesErrno::ENOENTwhen used inside of a VMWare shared folder on Windows. This adds
a fallback to
PDK::Util::Filesystem.mvthat first checks if the sourcefile exists (in case the error is legitimate) and then "moves" the file
using copy and remove operations.
As this is quite the corner case, there are no tests added but I've
tested it on a local VM and it resolves the issue.