(#806) Use ASCII quotes instead of Unicode quotes #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotje
approved these changes
Nov 22, 2019
glennsarti
approved these changes
Nov 22, 2019
|
I'm kinda surprised there isn't a rubocop plugin for smart-quotes to be honest |
|
Yeah, same. I had a search around on rubygems.org but couldn't find one 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a custom RuboCop cop to detect any smart quotes that sneak in in the future. It can automatically fix smart single quotes, fixing double quotes can be implemented if needed in the future.
Fixes #806