(PDK-1556) Use the module root when generating objects #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the `pdk new` command used the current directory as the module root which caused errors when users executed `pdk new` when deep inside a module. This commit changes the CLI to use the actual module root when creating the generators, and updates the tests for this scenario.
glennsarti
force-pushed
the
pdk-1556-pdk-new-root
branch
from
9eba5bd
to
9b18ffc
Compare
rodjek
approved these changes
Jan 8, 2020
Previously the module convert and update operations always assumed the user was in the module root. This caused many files to be erronously added to modules if the operation was started deep within the module. This commit changes the update and convert classes to accept a module_dir parameter which explicitly tells the converter/updater where the module root is so that it can make better decisions on module information (e.g. metadata or spec files) This commit also updates the tests for the new required parameter.
glennsarti
force-pushed
the
pdk-1556-pdk-new-root
branch
from
99aaaea
to
3c1f970
Compare
|
This PR does change the output of |
rodjek
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
pdk newcommand used the current directory as the module rootwhich caused errors when users executed
pdk newwhen deep inside a module.This commit changes the CLI to use the actual module root when creating the
generators, and updates the tests for this scenario.