(PDK-1557) Detect Control Repositories #826
Conversation
lib/pdk/control_repo.rb
Outdated
| elsif in_control_repo_root?(Dir.pwd) | ||
| Dir.pwd |
There was a problem hiding this comment.
If we are requiring an environment.conf to be present to consider something a control-repo, what additional benefit does this branch get us versus the find_upwards search? (find_upwards checks in pwd first before moving up the tree)
There was a problem hiding this comment.
in_control_repo_root? looks for things that like like a control repo (e.g. Puppetfile) whereas this method looks for something explicit. TBH this is mostly a copy-paste from the module detection.
I'm still in two minds about the whole explicit vs fuzzy search. The docs clearly state that "environment.conf" == Control Repo and Puppet itself will error if it's not present. Whereas in module land, Puppet will use a directory without a metadata.json happily, but we prefer a metadata.json.
There was a problem hiding this comment.
@rodjek Thoughts?
There was a problem hiding this comment.
Had a chat with @rodjek. And while non-directory based environment control repos do exist, they are not the preferred way. Also detecting them is problematic as they don't have an easily identifiable thing to search for.
So for this PR find_control_repo_root will look for environment.conf whereas control_repo_root? will look for something that could be a control repo. Use cases:
find_control_repo_rootwould be used in apdk validateoperationcontrol_repo_root?would be used in apdk convertoperation
glennsarti
force-pushed
the
pdk-1557-detect-control-repo
branch
from
bcf66e0
to
565f88d
Compare
Previously the PDK treats everything as a module. This commit begins the work to add Control Repo support by detecting Control Repositories and Bolt Project directories.
glennsarti
force-pushed
the
pdk-1557-detect-control-repo
branch
from
565f88d
to
03adc8f
Compare
|
@scotje Ready for review again. |
Previously the PDK treated everything as a module. This commit begins the work
to add Control Repo support by detecting Control Repositories and Bolt Project
directories.