(PDK-1590) Remove Gemfile.lock before running bundle update #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the 2.4 and 2.5 runtimes have updated to use Bundler 2.x but the 2.1 runtime is stuck on Bundler 1.x, we need to remove the Gemfile.lock manually during the version_selection package tests as Bundler 1.x hard fails when it encounters a 2.x lockfile. This is not a problem with other PDK commands as they update the lockfile before shelling out but we deliberately don't do that for `pdk bundle`.
scotje
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the 2.4 and 2.5 runtimes have updated to use Bundler 2.x but the 2.1
runtime is stuck on Bundler 1.x, we need to remove the Gemfile.lock
manually during the version_selection package tests as Bundler 1.x hard
fails when it encounters a 2.x lockfile. This is not a problem with
other PDK commands as they update the lockfile before shelling out but
we deliberately don't do that for
pdk bundle.