(PDK-1612) Add PDK::Context and context detection #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a typo error in the memoization test for PDK.config as it was accidentally testing PDK.logger.
rodjek
reviewed
Feb 18, 2020
Previously the PDK assumed it was always within a Puppet Module, but the PDK can be used in far more different contexts. This commit implements the PDK Context RFC [1], in preparation for other parts of the PDK to consume it, for example PDK validators: * Adds the base Context and three concrete contexts: None, Module and ControlRepo * Adds a memoized context object to PDK (PDK.context), for consumption by other parts of the PDK * Updates the module pdk compatibility methods to accept a module path instead of assume the PDK is always in a module. This is needed for the Module context to check if an arbitrary module is PDK compatible * Adds two test fixtures (a Puppet module and a control repo) for use by rspec for contex detection * Adds tests for context detection via PDK::Context.create [1] https://github.com/puppetlabs/pdk-planning/blob/master/RFCs/0007-add-pdk-context.md
glennsarti
force-pushed
the
pdk-1612-add-pdk-context
branch
from
d075099
to
6429d25
Compare
rodjek
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the PDK assumed it was always within a Puppet Module, but the PDK can
be used in far more different contexts. This commit implements the PDK Context
RFC [1], in preparation for other parts of the PDK to consume it, for example
PDK validators:
ControlRepo
parts of the PDK
of assume the PDK is always in a module. This is needed for the Module context
to check if an arbitrary module is PDK compatible
for contex detection
[1] https://github.com/puppetlabs/pdk-planning/blob/master/RFCs/0007-add-pdk-context.md