Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PDK-1615) Add Ini File configuration support #856

Merged
merged 1 commit into from
Feb 20, 2020
Merged

(PDK-1615) Add Ini File configuration support #856

merged 1 commit into from
Feb 20, 2020

Conversation

glennsarti
Copy link
Contributor

This commit adds an Ini File configuration namespace which can read and write to
Ini files. This is needed for reading environment.conf in control repositories.

@glennsarti
(PDK-1615) Add Ini File configuration support
9f00a3d 
This commit adds an Ini File configuration namespace which can read and write to
Ini files. This is needed for reading environment.conf in control repositories.
@glennsarti glennsarti requested a review from a team as a code owner February 19, 2020 06:03
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 91.358% when pulling 9f00a3d on glennsarti:add-inifile-config-file into bfcd14a on puppetlabs:master.

scotje
scotje approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@scotje scotje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, this is just based on the internal puppetlabs/puppet INI file implementation?

rodjek
rodjek approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@rodjek rodjek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: Would prefer to fix the style of the imported code to match our style rules rather than disable the checks but I don't really feel strongly about it to block the PR :)

@glennsarti
Copy link
Contributor Author

@rodjek Yeah, understand. I kept the original code formatting to make it easier in the future to copy-pasta any updates from the puppet code-base. But it's basically pick your poison.

@glennsarti
Copy link
Contributor Author

this is just based on the internal puppetlabs/puppet INI file implementation?

Yes.

@glennsarti glennsarti merged commit 98a52bc into puppetlabs:master Feb 20, 2020
@rodjek rodjek added this to the February 2020 milestone Feb 26, 2020
@rodjek rodjek added the feature label Feb 26, 2020
@glennsarti glennsarti deleted the add-inifile-config-file branch March 5, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotje scotje scotje approved these changes

@rodjek rodjek rodjek approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
February 2020
Development

Successfully merging this pull request may close these issues.
4 participants
@glennsarti @coveralls @scotje @rodjek