Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-1108) Add pdk set config command #859

Merged
merged 5 commits into from
Mar 5, 2020

Commits on Feb 28, 2020

  1. (PDK-1108) Add PDK::Config.set method

    Previously the PDK::Config class could only read (get) values, it could not set
    them easily, and lacked logic to deal with different value types, for example
    if you set a deep hash value, then the save data method on the namespace was
    not triggered.
    
    This commit:
    
    * Adds a PDK::Config.set method which takes into account nested namespaces,
      setting deep hashes, creates missing hash structures, and can add to, or
      explicitly set array, values.  All of this is necessary for the CLI component
    
    * Adds tests for the different scenarios
    glennsarti committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    8e2aa10 View commit details
    Browse the repository at this point in the history
  2. (PDK-1108) Add pdk set config command

    Now that the PDK::Config class now has a set method, we can add a `set config`
    CLI command so users can set configuration values.  Later commits will add the
    `remove config` CLI command.
    
    This commit:
    * Adds the basic `pdk set config` command
    * Adds type conversion using the `--type` parameter
    * Adds tests for the CLI command
    glennsarti committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    05a10d5 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. (PDK-1108) Add package tests for PDK get and set config

    Previously there were no full tests for the get and set configuration.  This
    commit adds package-testing tests which modifies configuration files on actual
    systems during testing.
    glennsarti committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    077da68 View commit details
    Browse the repository at this point in the history
  2. (PDK-1108) Remove deprecated PDK::Config method calls

    Previously many calls within the PDK used `.user` directly.  However now that
    there is a formal get and set method, accessing these directly is no longer
    required and is a private API.  This commit updates any references to these
    private methods and changes them to use .get and .set appropriately.
    glennsarti committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    9364cde View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. (PDK-1108) Use idiomatic rspec-mocks

    This commit updates the tests to use the anything matchcer instead of Object as
    per recommended practice in rspec-mocks.
    glennsarti committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    d9458b1 View commit details
    Browse the repository at this point in the history