Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) avoid interfering with local ruby configs #86

Merged
merged 2 commits into from
Jun 15, 2017

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Jun 15, 2017

No description provided.

@scotje
Copy link
Contributor

scotje commented Jun 15, 2017

Is this confusing Travis/Appveyor?

@DavidS
Copy link
Contributor Author

DavidS commented Jun 15, 2017

IIRC this is used by rvm to determine which ruby to use. I'm not sure if other tools might not evaluate this too. Since we're still having troubles sorting out our dev and test environments, I'd prefer not to have such landmines around.

@scotje
Copy link
Contributor

scotje commented Jun 15, 2017

Yeah, it's specifically how rbenv tracks what version it should switch to for the project, not sure if RVM adopted it as well. Let's maybe add it to .gitignore so we can still use it locally in our dev environments if needed?

@scotje
Copy link
Contributor

scotje commented Jun 15, 2017

(I will push a commit to add to .gitignore)

@scotje scotje merged commit a217e3f into puppetlabs:master Jun 15, 2017
@DavidS DavidS deleted the avoid-interfering branch June 16, 2017 10:15
@DavidS DavidS added the bug label Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants