(SDK-274) Adds --version option #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmjen
force-pushed
the
version-info
branch
2 times, most recently
from
abbf4e3
to
4b521d5
Compare
bmjen
commented
Jun 19, 2017
lib/pdk/util/version.rb
Outdated
| end | ||
|
|
||
| def self.pdk_ref | ||
| ref = pkg_sha || git_ref |
There was a problem hiding this comment.
Debating flipping this prioritization. I think if someone installs the official pdk package, but modifies the underlying code (with an initialized git repo), we should be aware of that.
There was a problem hiding this comment.
In that case it would be good to know both, so maybe they should just each be conditionally added if available?
scotje
reviewed
Jun 19, 2017
| sha = ver.strip.split('.')[-1] unless ver.nil? | ||
| end | ||
|
|
||
| sha |
There was a problem hiding this comment.
Seems likesha is going to be an undefined var if the version file doesn't exist?
There was a problem hiding this comment.
If the version file doesn't exist, I'm expecting it to return nil so that we can fall back to git_ref up above.
There was a problem hiding this comment.
Oh right, ruby hoists vars out of if/else blocks.
scotje
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow easy checking and reporting of the current pdk version, {{--version}} should report the installed version of PDK, as well as the vanagon build SHA from a built package or the git ref from a local git repo.