(#876) Refactor text report output when validators are skipped #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotje
force-pushed
the
876_validate_newline
branch
3 times, most recently
from
2f8c795
to
a76ee00
Compare
Refactors how notifications about skipped validators are output. A message is now logged prior to validator execution at the `INFO` level when a validator is skipped. Text format reports now suppress events with a "skipped" status. (JUnit reports still include them.) Lastly, a newline is always added to the end of a text format report which resolves the UI bug described by puppetlabs#876.
scotje
force-pushed
the
876_validate_newline
branch
from
a76ee00
to
6a248e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors how notifications about skipped validators are output. A
message is now logged prior to validator execution at the
INFOlevelwhen a validator is skipped. Text format reports now suppress events
with a "skipped" status. (JUnit reports still include them.)
Lastly, a newline is always added to the end of a text format report
which resolves the UI bug described by #876.