Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set a forge token for release #912

Closed
wants to merge 1 commit into from

Conversation

logicminds
Copy link
Contributor

  • Previously when using the release command the user
    had to enter the forge token every time they released.
    This is annoying and is not compatible with CI systems.

    This commit allows the user or CI to set PUPPET_FORGE_TOKEN
    environment variable so they are not burdened with prompts.

    This also makes the default cli option the value of the environment variable.

    Note: when help is displayed the token is also displayed.

  * Previously when using the release command the user
    had to enter the forge token every time they released.
    This is annoying and is not compatible with CI systems.

    This commit allows the user or CI to set PUPPET_FORGE_TOKEN
    environment variable so they are not burdened with prompts.

    This also makes the default cli option the value of the environment variable.

    Note: when help is displayed the token is also displayed.
@logicminds logicminds requested a review from a team as a code owner August 26, 2020 06:16
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.649% when pulling aaae3ed on nwops:token into 226a101 on puppetlabs:master.

@scotje scotje mentioned this pull request Aug 27, 2020
@scotje
Copy link
Contributor

scotje commented Aug 27, 2020

Superseded by #913

@scotje scotje closed this Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants