-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to generate new facts #921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great, still needs CI sorted.
- was trying to use pdk-templates#main, which didn't have the template yet; it is merged now
- rubocop complaining about whitespace - will push a fixup in a second - see Add ability to generate new facts #923
@logicminds the test failures (now that the pdk-templates change has been merged) looks a lot more sensible. Can you work with those? |
d8e72d1
to
849ec91
Compare
* previously there was not a way to create facts from the new command. This adds a generator to create the fact and spec file.
I updated the code and removed the failing tests. I don't know how these tests work and without docs I can really move forward without wasting time. A document for acceptance testing generators would be great. I have another branch with a functions generator coming as well. |
Hi @logicminds, Thanks for your contribution, this looks good 👍 |
This adds a new generator to create facts. This must be merged along with puppetlabs/pdk-templates#361.
Currently these tests are failing as I need help figuring out why. Real world testing seems to work fine.
Below is a video showing the usage. The fact generated is very basic as is the spec file but this is enough to save a few minutes from the user.