(GH-905) Ensure release failure includes error message #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures in acceptance testing seem unrelated, I'm not sure what's going on there. |
|
Some of those failures are addressed in 4abaa34 - I'm still working on the sudden time out on the erroring cell |
Prior to this commit, a failure to publish to the forge returns the string representing a Net::HTTPBadRequest object instead of text including the actual error message. This commit ensures that the body of the error is instead written to the error stream.
michaeltlombardi
deleted the
gh-905/master/add-release-failure-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, a failure to publish to the forge returns the string representing a
Net::HTTPBadRequestobject instead of text including the actual error message. This commit ensures that the body of the error is instead written to the error stream.Resolves #905