Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add completion for resource-like declarations #181

Closed
glennsarti opened this issue Sep 16, 2019 · 1 comment · Fixed by #180
Closed

Add completion for resource-like declarations #181

glennsarti opened this issue Sep 16, 2019 · 1 comment · Fixed by #180
Milestone
0.22.0

Comments

@glennsarti
Copy link
Contributor

As per https://puppet.com/docs/puppet/latest/lang_classes.html#section-x54-1hk-xhb it is possible to do resource-like declarations for Puppet types e.g.

class {'apache':
  version => '2.2.21',
}

Resource-like declarations look like normal resource declarations, using the class pseudo-resource type. You can provide a value for any class parameter by specifying it as a resource attribute.

The completion provider should provide parameter and property completions for this type of declaration.
@glennsarti
Copy link
Contributor Author

PR originally created by @juliosueiras

#180

glennsarti added a commit to juliosueiras/puppet-editor-services that referenced this issue Sep 16, 2019
@glennsarti
(puppetlabsGH-181) Add unit tests for resource like declarations
90fbee9 
This commit adds unit tests for resource like declarations in the completion
provider.

Note that unit tests are unsed instead of integration tests as part of the push
to move many of the integration tests into unit.
glennsarti added a commit to juliosueiras/puppet-editor-services that referenced this issue Sep 16, 2019
@glennsarti
(puppetlabsGH-181) Refactor resource-like class detection
672bdad 
This commit refactors the resource-like class detection to reduce duplicated
code and adds more comments on this pseudo resource.
@juliosueiras juliosueiras mentioned this issue Sep 16, 2019
Merged
@glennsarti glennsarti added this to the 0.22.0 milestone Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.22.0
Development

Successfully merging a pull request may close this issue.

Added completion for resource-like class juliosueiras/puppet-editor-services
1 participant
@glennsarti