Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Update rubocop to 0.80.x #234

Merged
merged 1 commit into from
Apr 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Style/NumericLiterals:
Enabled: false

# Length is not useful indicator
Metrics/LineLength:
Layout/LineLength:
Enabled: false
Metrics/MethodLength:
Enabled: false
Expand Down Expand Up @@ -95,3 +95,20 @@ Style/SafeNavigation:
# This is not valid on Ruby 2.1
Layout/HeredocIndentation:
Enabled: false

# Rubocop 0.80.0 rules
Style/HashEachMethods:
Enabled: false

Style/HashTransformKeys:
Enabled: true

Style/HashTransformValues:
Enabled: true

# Rubocop 0.80.1 rules
Lint/RaiseException:
Enabled: true

Lint/StructNewOverride:
Enabled: true
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ group :development do
gem 'rspec', '>= 3.2', :require => false

if Gem::Version.create(RUBY_VERSION) >= Gem::Version.create('2.3.0')
gem "rubocop", ">= 0.77.0", :require => false, :platforms => [:ruby, :x64_mingw]
gem "rubocop", ">= 0.80.0", :require => false, :platforms => [:ruby, :x64_mingw]
end

if ENV['PUPPET_GEM_VERSION']
Expand Down