(maint) Mergeup master into 1.0 #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that Facter 4.0.16 is resetting the Facter search dirs which then causes the sidecar to not find some external or custom facts. This commit monkey patches the Facter module and makes it possible to limit the number of resets to one.
(puppetlabsGH-238) Monkey patch Facter for minimal resets
Co-Authored-By: David Schmitt <david.schmitt@puppet.com>
(maint) Update branding urls
This reverts commit f8e88a5.
Revert "(puppetlabsGH-238) Monkey patch Facter for minimal resets"
…-endpoint GH 242 facts endpoint
This commit adds an acceptance test for the puppet/getFacts request. Previously this message was added to the message handler, but not to the test suite.
Previously the puppet/getFacts request would call out to Facter directly however this can be very slow, particularly with Facter v2 in the PDK. This commit changes the request to instead use the object cache which already has all of the available facter information. This commit also moves the method from the PuppetHelper to the FacterHelper where it would make more sense. This is tested as part of the acceptance suite.
Now that the language server no longer calls the facts_all action, the supporting code can be removed.
(puppetlabsGH-245) Use object cache for fact data
(maint) Release 0.26.0
…services into mergeup-master * 'master' of https://github.com/glennsarti/puppet-editor-services: (maint) Release 0.26.0 (puppetlabsGH-245) Remove facts_all sidecar request (puppetlabsGH-245) Use object cache for fact data (puppetlabsGH-245) Add acceptance tests for getFacts request (puppetlabsGH-242) Puppet Facts Endpoint Revert "(puppetlabsGH-238) Monkey patch Facter for minimal resets" (maint) Update branding urls (puppetlabsGH-238) Monkey patch Facter for minimal resets (maint) Update rubocop to 0.80.x
This commit updates the Facter Helper for 1.0, due to the change in the session state.
|
Self merging this as it's a mergeup from master (already reviewed) and 1.0 is not released yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.