Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RK-342) Update for behavior change in Cri options hash #934

Closed
wants to merge 1 commit into from

Conversation

donoghuc
Copy link
Member

With the release of cri 2.15.7 flags are now always included in the options hash with the value set to false. This was causing errors in the R10k::Util::Setops setops method when executing puppetfile or deploy actions. This commit adds help to the allowed_initialize_opts in the R10k::Action::Base class

With the release of cri 2.15.7 flags are now always included in the options hash with the value set to `false`. This was causing errors in the `R10k::Util::Setops` setops method when executing puppetfile or deploy actions. This commit adds `help` to the `allowed_initialize_opts` in the `R10k::Action::Base` class
@donoghuc
Copy link
Member Author

For sure not a full solution. I think we will need to add some more (for example no-force would likely need to be added to;

def allowed_initialize_opts
). I just put this up based on how i was hacking around it yesterday instead of trying to explain in in a comment on the ticket.

@justinstoller
Copy link
Member

@pcarlisle you said you were going to work with those involved on a longer term solution, is this part of that?

@pcarlisle
Copy link
Contributor

Unfortunately this is more complex and can't be fully solved on this version of cri. We're waiting on an upstream patch that's in progress which will give a more full solution to this. denisdefreyne/cri#94

@pcarlisle pcarlisle closed this Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants