Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Generic instance for Either #57

Closed

Conversation

paulyoung
Copy link
Contributor

@paulyoung paulyoung commented Oct 22, 2020

purescript-deprecated/purescript-generics-rep#34 (comment) says:

The instance for Either should live in purescript-either instead, and should be derivable.

I'm not sure if the concerns expressed in that other PR apply here.

@hdgarrood
Copy link
Contributor

This one does still apply:

I’d prefer to consider all of the data types across the core libraries and come up with a uniform approach for making sure all of the types which should have a Generic instance do.

@paulyoung
Copy link
Contributor Author

@garyb had a suggestion along those lines here: purescript-deprecated/purescript-generics-rep#43 (comment)

@@ -19,6 +19,7 @@
"purescript-bifunctors": "master",
"purescript-control": "master",
"purescript-foldable-traversable": "master",
"purescript-generics-rep": "master",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll be moving the generics-rep repo's code into prelude, so we can drop the dependency on generics-rep.

@JordanMartinez
Copy link
Contributor

Superceded by #61, which builds off this PR but removes the generics-rep dependency because it was ported to prelude.

@paulyoung paulyoung deleted the paulyoung/generic-either branch December 26, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants