Port Enum parts of generics-rep to this repo #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix instances for record fields
Break up modules
* Initial work on deriving Show * Add test for Show * Remove import * Travis etc.
* Data.Generic.Rep.Bounded Generic implementations of Prelude.Bounded class's top and bottom. * GenericBounded - don't support product types * GenericBounded - only support NoArguments
Update for PureScript 0.11
Add classes for Enum deriving
Product instances in Bounded and Enum
…20) * Added Eq and Show instances to NoArguments and NoConstructors * Added GenericShowFields * Removed Show, Eq * Cleanup * Removed NoConstructors Show instance
Updates for 0.12
Add guide
57 tasks
kl0tl
reviewed
Dec 22, 2020
test/Test/Data/Main.purs
Outdated
| @@ -0,0 +1,149 @@ | |||
| module Test.Data.GenericsRep where | |||
There was a problem hiding this comment.
Should we name this module Test.Data.Enum.Generic, since we’re testing the generic implementations exported from Data.Enum.Generic?
test/Main.purs
Outdated
| main = testEnum | ||
| main = do | ||
| testEnum | ||
| testGenericsRep |
There was a problem hiding this comment.
What about testGenericEnum, since we’re testing generic implementations for Enum and BoundedEnum?
kl0tl
approved these changes
Dec 24, 2020
|
I know this got approval, but on second thought, I should do the same thing I did in |
|
I've updated this PR to include the git history using the same command from before. @kl0tl If you still approve, please indicate so via a comment. |
thomashoneyman
approved these changes
Dec 25, 2020
|
Thank you very much for remembering about the history preservation 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.