Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change NoConstructors to newtype Void #282

Merged
merged 3 commits into from
Mar 14, 2022
Merged

Change NoConstructors to newtype Void #282

merged 3 commits into from
Mar 14, 2022

Conversation

JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Feb 15, 2022 •
edited
Loading

Description of the change

Fixes #247. I think purescript-newtype would need to add a Newtype instance for NoConstructors...?

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez JordanMartinez added purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump. labels Feb 15, 2022
@thomashoneyman
Copy link
Member

I'm not sure this is a breaking change, but no harm in treating it with care. 👍

@JordanMartinez JordanMartinez merged commit 2ab0477 into purescript:master Mar 14, 2022
@JordanMartinez JordanMartinez deleted the updateNoConstructors branch March 14, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[generics-rep] newtype NoConstructors = NoConstructors Void
2 participants
@JordanMartinez @thomashoneyman