Remove proxy types #288
Merged
Remove proxy types #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanMartinez
added
type: breaking change
CHANGELOG.md
Outdated
| @@ -7,8 +7,8 @@ Notable changes to this project are documented in this file. The format is based | |||
| Breaking changes: | |||
| - Migrated FFI to ES Modules (#287 by @kl0tl and @JordanMartinez) | |||
| - Change Generic Rep's `NoConstructors` to newtype `Void` (#282 by @JordanMartinez) | |||
| - Replace `forall proxy. proxy k` workaound with `Proxy k` (#281 by @JordanMartinez) | |||
| - Drop all kind-specific Proxy types (e.g. `Proxy2`, `Proxy3`) (#281 by @JordanMartinez) | |||
| - Replace `forall proxy. proxy k` workaound with `Proxy k` (#281, #288 by @JordanMartinez) | |||
There was a problem hiding this comment.
Mind switching this to the verbiage we've been using in the other PRs?
thomashoneyman
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Follows up with #284 by removing all kind-specific Proxy types that were missed in that PR.
Checklist: