Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Restored extras_require #21

Merged
merged 1 commit into from
Jan 24, 2018
Merged

Restored extras_require #21

merged 1 commit into from
Jan 24, 2018

Conversation

jmichalicek
Copy link

  • Restored extras_require to handle different dependencies for python 3.0+ vs 2.7

* Restored extras_require to handle different dependencies for
  python 3.0+ vs 2.7
@codecov-io
Copy link

codecov-io commented Jan 6, 2018

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   89.58%   89.58%           
=======================================
  Files           8        8           
  Lines         461      461           
=======================================
  Hits          413      413           
  Misses         48       48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba1026b...3a450d5. Read the comment docs.

@tomviner
Copy link

+1. Tested and this branch is required for me to install with Django 1.10 and Python 2.

@bhrutledge
Copy link

👍 I'm happy to report that requiring -e git+https://github.com/jmichalicek/dj-pagination.git@restore-extras-require#egg=dj-pagination leads to a successful pip install on Django 1.11.9 and Python 2.7.14.

Could this get merged and released? I'm preparing for a deployment of a Django upgrade.

@pydanny pydanny merged commit fdb9750 into pydanny:master Jan 24, 2018
@pydanny
Copy link
Owner

pydanny commented Jan 24, 2018

Released 2.3.2: https://pypi.python.org/pypi/dj-pagination

@jmichalicek
Copy link
Author

Thanks @pydanny

@bhrutledge @tomviner I've been running into this sort of thing on and off with various packages. Not sure why I never mentioned it here, but another temporary workaround for this sort of issue is to install Django first. I was typing this up right while it got released, so managed to get in an example before pypi updates.

(djpag) ➜  dj-pagination-test python --version
Python 2.7.13
(djpag) ➜  dj-pagination-test pip install 'django<2'
Collecting django<2
  Using cached Django-1.11.9-py2.py3-none-any.whl
Requirement already satisfied: pytz in /Users/justin/.pyenv/versions/2.7.13/envs/djpag/lib/python2.7/site-packages (from django<2)
Installing collected packages: django
Successfully installed django-1.11.9
(djpag) ➜  dj-pagination-test pip install dj-pagination
Requirement already satisfied: dj-pagination in /Users/justin/.pyenv/versions/2.7.13/envs/djpag/lib/python2.7/site-packages
Requirement already satisfied: Django<2.0,>=1.8; python_version < "3.0" in /Users/justin/.pyenv/versions/2.7.13/envs/djpag/lib/python2.7/site-packages (from dj-pagination)
Requirement already satisfied: pytz in /Users/justin/.pyenv/versions/2.7.13/envs/djpag/lib/python2.7/site-packages (from Django<2.0,>=1.8; python_version < "3.0"->dj-pagination)

I was also been mucking about with the --no-deps flag which I expected to solve it, but it still seems to check versions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants