Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Schema equivalence tests #18

Closed
samuelcolvin opened this issue Dec 1, 2023 · 0 comments · Fixed by #70
Closed

JSON Schema equivalence tests #18

samuelcolvin opened this issue Dec 1, 2023 · 0 comments · Fixed by #70
Labels

Comments

@samuelcolvin
Copy link
Member

The whole point of FastUI is that we give some level of guarantee that the Pydantic models in the backend match the TS interfaces in the react app, but currently there's no test to catch if that's not the case.

To check consistency, we should generate JSON Schema for the component props interfaces, and for the pydantic models, and check they match. There will probably need to be some edge cases skipped or specially accounted for.

The tests should be written in Python, as little code as possible should be in node/ts.

samuelcolvin added a commit that referenced this issue Dec 5, 2023
samuelcolvin added a commit that referenced this issue Dec 11, 2023
pablogamboa added a commit to pablogamboa/FastUI that referenced this issue Feb 16, 2024
remove caveat from README.md as pydantic#18 has been already fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant