Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSE using @microsoft/fetch-event-source so we can post and control more #193

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

samuelcolvin
Copy link
Member

means:

  • SSE connections don't automatically reconnect
  • we can use methods other than GET
  • we can include headers for auth

Partly resolves #171

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d3a8e6c) 95.65% compared to head (6578cb8) 95.67%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
+ Coverage   95.65%   95.67%   +0.02%     
==========================================
  Files          14       14              
  Lines         943      948       +5     
==========================================
+ Hits          902      907       +5     
  Misses         41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuelcolvin samuelcolvin merged commit 345ab9f into main Feb 14, 2024
16 checks passed
@samuelcolvin samuelcolvin deleted the SSE-improvements branch February 14, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Methods
1 participant