Fix GoToEvent link generation when value is None #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (v === undefined) { | ||
| throw new Error(`field "${key}" not found in ${JSON.stringify(row)}`) | ||
| } else if (v === null) { | ||
| if (v === null || v === undefined) { | ||
| returnNull = true | ||
| return 'null' |
There was a problem hiding this comment.
Why do we return 'null' here and null below? Do we no longer need to raise an error?
There was a problem hiding this comment.
Why do we return 'null' here and null below?
Don't know.
Do we no longer need to raise an error?
I think we should keep it like that. I will change the implementation
hramezani
force-pushed
the
fix-link-render
branch
from
5c8b78e
to
5048431
Compare
|
Ok, I changed the implementation. The table renders without any error with my patch. you can see the row begins with 
but it fails without my patch: 
|
sydney-runkle
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.