Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add currency to DisplayMode #345

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Add currency to DisplayMode #345

merged 1 commit into from
Aug 22, 2024

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Aug 22, 2024

Naive implementation, hardcoding USD display

@Viicos
Copy link
Member Author

Viicos commented Aug 22, 2024

cc @Kludex

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.01%. Comparing base (16abe6a) to head (9f6065a).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   95.68%   97.01%   +1.33%     
==========================================
  Files          14       15       +1     
  Lines         950     1173     +223     
==========================================
+ Hits          909     1138     +229     
+ Misses         41       35       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sydney-runkle sydney-runkle merged commit 96aff04 into pydantic:main Aug 22, 2024
17 checks passed
@Viicos Viicos deleted the currency branch August 22, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants