Added footer component #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, Great work! 👍🏻 |
# Conflicts: # python/fastui/components/__init__.py # src/npm-fastui-bootstrap/src/footer.tsx # src/npm-fastui/src/components/footer.tsx # src/npm-fastui/src/components/index.tsx
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 120 120
=========================================
Hits 120 120 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 94.01% 94.05% +0.04%
==========================================
Files 11 11
Lines 718 723 +5
==========================================
+ Hits 675 680 +5
Misses 43 43 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Samuel Colvin <s@muelcolvin.com>
|
Thank you, looks great! |
|
The website is now broken: #135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I took some time to add a basic footer component. fixes #35
Currently, only supports one of the layouts from here with the horizontal links and an extra text (e.g. a copyright notice).
Styling is also made flexible such that it should look decent if one of the two elements is omitted.
With both:
With only links:
With only extra text: