Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patsy pickles #104

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

patsy pickles #104

wants to merge 17 commits into from

Commits on Nov 4, 2018

  1. Check that a builder roundtrips through pickle and will give the same… 

    … results afterwards.
    @chrish42 @thequackdaddy
    chrish42 authored and thequackdaddy committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    e555487 View commit details
    Browse the repository at this point in the history

  2. Beginning of work on pickling.

    @chrish42 @thequackdaddy
    chrish42 authored and thequackdaddy committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    4eab160 View commit details
    Browse the repository at this point in the history

  3. Beginning of igh-level tests for pickling.

    @chrish42 @thequackdaddy
    chrish42 authored and thequackdaddy committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    2413dfe View commit details
    Browse the repository at this point in the history

  4. Remove stray whitespace and indents.

    @chrish42 @thequackdaddy
    chrish42 authored and thequackdaddy committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    9b11406 View commit details
    Browse the repository at this point in the history

  5. In-progress work for pickling tests.

    @chrish42 @thequackdaddy
    chrish42 authored and thequackdaddy committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    0a51389 View commit details
    Browse the repository at this point in the history

  6. Add TODO comment.

    @chrish42 @thequackdaddy
    chrish42 authored and thequackdaddy committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    e1b0da3 View commit details
    Browse the repository at this point in the history

  7. Pickling of EvalFactor, with testcase for making sure origin is pickled.

    @chrish42 @thequackdaddy
    chrish42 authored and thequackdaddy committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    5ccaeb4 View commit details
    Browse the repository at this point in the history

  8. More fully fleshed-out version of pickling test harness.

    @chrish42 @thequackdaddy
    chrish42 authored and thequackdaddy committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    c158087 View commit details
    Browse the repository at this point in the history

  9. Better error message when unpickling a version that is not supported.

    @chrish42 @thequackdaddy
    chrish42 authored and thequackdaddy committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    24ce54c View commit details
    Browse the repository at this point in the history

  10. More flesh-out version of high-level tests for pickling design_info o… 

    …bjects.
    @chrish42 @thequackdaddy
    chrish42 authored and thequackdaddy committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    3afb878 View commit details
    Browse the repository at this point in the history

  11. Small code tweaks.

    @chrish42 @thequackdaddy
    chrish42 authored and thequackdaddy committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    8dd9023 View commit details
    Browse the repository at this point in the history

  12. Sample test pickle.

    @chrish42 @thequackdaddy
    chrish42 authored and thequackdaddy committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    d418368 View commit details
    Browse the repository at this point in the history

  13. Add TODO note for force=True future option for creating test pickles.

    @chrish42 @thequackdaddy
    chrish42 authored and thequackdaddy committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    f92d35b View commit details
    Browse the repository at this point in the history

  14. Adding __getstate__ and __setstate__ on relevant factors. Adding __eq… 

    …__ as appropriate to make assert tests work.
    @thequackdaddy
    thequackdaddy committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    08cb4f1 View commit details
    Browse the repository at this point in the history

  15. Added __getstate__ more appropriately, tests for pickling objects, an… 

    …d special tests for transform equivalence, new assert statement that makes the pickle a dict (not the most robust... but it works), added PickleError,
    @thequackdaddy
    thequackdaddy committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    0301817 View commit details
    Browse the repository at this point in the history

  16. Clean the EvalEnvironment before pickling to removing patsy's statefu… 

    …l transforms which have different names/qualnames from expected.
    @thequackdaddy
    thequackdaddy committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    019094d View commit details
    Browse the repository at this point in the history

  17. Getting closer on pickling 

    * Now run subset and clean the eval_env after
removing bare funcalls
* Had some straggling tuples
* Altered test so that stateful_transforms won't
be saved in eval_env
* Removed the clean method on EvalEnvironment
    @thequackdaddy
    thequackdaddy committed Nov 4, 2018
    Configuration menu
    Copy the full SHA
    b9f69d1 View commit details
    Browse the repository at this point in the history