Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: use fontawesome css variables instead of font names #1219

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

12rambau
Copy link
Collaborator

@12rambau 12rambau commented Feb 28, 2023

Fix #1195

Everything is in the title:

instead of relying on the name of the fonts embeded in fontawesome (which forces us to change them all if we change fa version, we now rely on the css variables injected by fontawesome distribution.

font: var(--fa-font-solid);

is equivalent to:

font-family: "Font Awesome 6 Free";
font-weight: 400;
font-size: 1em; 
line-height: 1;
font-style: normal;

I didn't changed the icon content with the SASS mixin. We would loose our capacity to reuse the icon elswhere as the variables needs to be scss compiled one. To be fair unicodes never change so I would say it's ok.

@12rambau 12rambau marked this pull request as ready for review February 28, 2023 13:50
@choldgraf
Copy link
Collaborator

The icons look good to me - and this is a nice simplification ! FYI it looks like you have the same lockfile update in this one too

@drammock drammock merged commit 39aa0d7 into pydata:main Mar 7, 2023
@12rambau 12rambau deleted the fontawesome branch March 7, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use SASS mixin for all our CSS icons
3 participants