Do not show announcement banner if announcement contents are empty #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add documentation about updating and removing announcement banners.
drammock
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Sorry for the slow review @melissawm
I pushed a commit to remove the else and dedent its contents (since we return in the if branch). I'll also add 2 tiny formatting fixes to the docs (which are otherwise perfect, thanks!)
|
ignoring codecov upload failures, which should be fixed by #1717 thanks @melissawm! |
jni
added a commit
to napari/docs
that referenced
this pull request
Feb 28, 2024
The survey has now closed. Until we build the docs with a release of pydata sphinx theme containing [this PR](pydata/pydata-sphinx-theme#1703), we can't remove the banner without rebuilding the docs entirely. Therefore, until our next release, we can have some helpful text at the top. 😊
ivanov
pushed a commit
to ivanov/pydata-sphinx-theme
that referenced
this pull request
Jun 5, 2024
…ydata#1703) * Do not show announcement banner if announcement contents are empty Also add documentation about updating and removing announcement banners. * dedent * Apply suggestions from code review --------- Co-authored-by: Daniel McCloy <dan@mccloy.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add documentation about updating and removing announcement banners.
Closes #1695