fix missing sphinx testing dependencies #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drammock
added
kind: maintenance
trallard
approved these changes
Mar 29, 2024
|
argh. things that work locally aren't working when run via the action. Will revisit next week, but if anyone knows the right combination of |
|
I can sort it out when I am back at work on Tuesday. |
|
OK I think I got it @trallard. The 3.12 CI is still failing, but it's failing at the codecov upload step, not when trying to import defusedxml when running the tests. |
drammock
commented
Apr 2, 2024
| fi | ||
| set -x # print commands | ||
| python -m pip install --upgrade pip wheel setuptools | ||
| python -m pip install -e .["$1"] ${SPHINX_INSTALL} $2 $DEP_EXTRA |
There was a problem hiding this comment.
FYI $DEP_EXTRA is probably cruft from whoever we copied this file from. It's never used by us.
There was a problem hiding this comment.
We can leave it for now 🤷🏽♀️ the whole thing needs an overhaul
|
Let's merge this as is since the codecov bit is the missing one atm |
ivanov
pushed a commit
to ivanov/pydata-sphinx-theme
that referenced
this pull request
Jun 5, 2024
* fix missing sphinx testing dependencies * do the specifier correctly * fix quoting * fix again * try another way * try quoting again * try without whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @trallard this should fix the
defusedxmlerrors. It was added as a new optional dependency to sphinx within the last week. It seems like we were already getting all the other sphinx[test]deps in other ways (just by luck) so strictly speaking I could have just added[test]to the sphinx dev URL, but why leave it fragile if we don't have to.