Wrap tables in scrollable div #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabalafou
commented
May 21, 2024
| @@ -81,9 +81,17 @@ def visit_table(self, node): | |||
| if "align" in node: | |||
| classes.append(f'table-{node["align"]}') | |||
|
|
|||
| # put table within a scrollable container because overflow on display: table does nothing | |||
There was a problem hiding this comment.
It's actually the width property that doesn't really do anything other than act as a kind of minimum width for the table
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Carreau
approved these changes
May 22, 2024
|
Let's try. |
Carreau
added
tag: design
Merged
ivanov
pushed a commit
to ivanov/pydata-sphinx-theme
that referenced
this pull request
Jun 5, 2024
Carreau
pushed a commit
that referenced
this pull request
Jun 27, 2024
#1827 introduced an [Axe accessibility regression](https://dequeuniversity.com/rules/axe/4.0/scrollable-region-focusable). See also: - #1787 - #1428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1824.