Fix url shortening for gitlab, and more test for github #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes pydata#1887 Note that some non cannonical url (not having /-/) are not properly shortened.
drammock
reviewed
Jun 18, 2024
tests/test_short_url.py
Outdated
| "gitlab-org/gitlab#375583", | ||
| ), | ||
| ( | ||
| # todo, non cannonical url, needs extra parsing. |
There was a problem hiding this comment.
is this TODO still outstanding? Looks like all tests are passing...
There was a problem hiding this comment.
I think that both gitlab.com/foo/bar/issues and gitlab.com/foo/bar/-/issues should shorten to the same.
It's more a good to have but would be an extra feature for another time.
Carreau
changed the title
drammock
approved these changes
Jun 19, 2024
|
Since this has been approved and CI is happy I will go ahead and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1887
Note that some non cannonical url (not having /-/) are not properly shortened.