ENH - Update bundling and vendoring (JS) #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trallard
added
kind: enhancement
trallard
commented
Aug 16, 2024
trallard
commented
Aug 16, 2024
webpack.config.js
Outdated
| // Extracts CSS for each JS file that includes CSS | ||
| { loader: MiniCssExtractPlugin.loader }, | ||
| { | ||
| // Interprets `@import` and `url()` like `import/require()` and will resolve them |
There was a problem hiding this comment.
Needed so that we can include FA directly in our stylesheets
webpack.config.js
Outdated
Comment on lines
162
to
168
| // Font vendoring and management - will separate FA and export the font files | ||
| test: /\.(woff|woff2|eot|ttf|otf)$/i, | ||
| type: 'asset/resource', | ||
| generator: { | ||
| filename: 'vendor/fontawesome/webfonts/[name][ext]' | ||
| } | ||
| },], |
There was a problem hiding this comment.
This replaces the previous approach where we copied the files from node_modules and instead resolves the import and extracts the font files to our vendor directory
Coverage report
This PR does not seem to contain any modification to coverable code. |
Carreau
reviewed
Aug 28, 2024
Carreau
approved these changes
Aug 28, 2024
|
Looks good to me, restarted the test as the failure was unrelated, and likely due to a homebrew update. |
|
Thanks for the review @Carreau, since there do not seem to be any blockers, I will go ahead and merge 🚀 |
trallard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to improve our approach to bundling theme assets.
As you go through the PR, you will notice some changes, such as:
@import "variables/bootstrap";imported twice? #1788)Closes: #1613
Closes: #1788