Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix example gallery screenshot for scikit-learn #1990

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Charlie-XIAO
Copy link
Contributor

@Charlie-XIAO Charlie-XIAO commented Sep 20, 2024

Follow up #1985, there seems to something wrong with the generated screenshot, probably because the root has a canonical link that points to stable. Sorry for the mistake.

Before After
image image

Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@drammock drammock merged commit 8402882 into pydata:main Sep 20, 2024
25 checks passed
@Charlie-XIAO Charlie-XIAO deleted the sklearn-screenshot branch September 20, 2024 16:30
gabalafou pushed a commit to gabalafou/pydata-sphinx-theme that referenced this pull request Oct 6, 2024
Follow up pydata#1985, there seems to something wrong with the generated
screenshot, probably because the root has a canonical link that points
to stable. Sorry for the mistake.

| Before | After |
| :----: | :---: |
|
![image](https://github.com/user-attachments/assets/b40e6741-e74f-46ed-882c-b2850eeacf1b)
|
![image](https://github.com/user-attachments/assets/41081b68-5e64-4968-8511-f8bf0e7b2ed2)
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants